Updated ISettings dataclass for imageInference support#288
Updated ISettings dataclass for imageInference support#288Sirsho1997 wants to merge 3 commits intomainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Comment |
Sirsho1997
changed the title
There was a problem hiding this comment.
Pull request overview
This PR appears intended to extend the shared ISettings payload used across inference APIs and to add document preprocessing for text inference requests. In the SDK overall, these changes affect the public request dataclasses in runware/types.py and the text request preparation path in runware/base.py.
Changes:
- Added
search: Optional[bool] = NonetoISettings. - Reordered and regrouped the
ISettingsdataclass fields. - Added document preprocessing in
_requestTextbefore building text inference requests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
runware/types.py |
Updates the shared ISettings dataclass, including the new search field and a full field reordering. |
runware/base.py |
Adds preprocessing for inputs.documents in the non-streaming text inference request path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ISettingsnow includes:search: Optional[bool] = None